Convert comma separated presets/plugins into an array #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzoo
reviewed
Feb 26, 2018
src/upgradeConfig.js
Outdated
| let presets = config.presets; | ||
|
|
||
| if (!Array.isArray(presets) && typeof presets === 'string') { | ||
| presets = config.presets = [config.presets]; |
There was a problem hiding this comment.
We actually need it to be an array of strings not just make it an array 😛
So like a split on ","?
hiroppy
force-pushed
the
feature/convert-comma-to-array
branch
from
81f3763 to
494ce9c
Compare
hiroppy
force-pushed
the
feature/convert-comma-to-array
branch
from
494ce9c to
3ad2f31
Compare
|
@hzoo PTAL:) |
existentialism
approved these changes
Feb 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.