Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various snippet improvements #6

Merged
merged 1 commit into from
Jan 17, 2015
Merged

Various snippet improvements #6

merged 1 commit into from
Jan 17, 2015

Conversation

zertosh
Copy link
Member

@zertosh zertosh commented Jan 17, 2015

Don't get too attached to getDOMNode and isMounted - they're going away (see facebook/react#2805). When React 0.13.0 lands I'll update these accordingly - like this.getDOMNode() -> React.findDOMNode(instance)

* Component API snippets now have "this."
* "getDefaultProps" now has the value placeholder for the key
* Added "this.getDOMNode"
* Sorted the "snippets" list in the README
zertosh added a commit that referenced this pull request Jan 17, 2015
Various snippet improvements
@zertosh zertosh merged commit 86a4bd9 into master Jan 17, 2015
@dashed
Copy link

dashed commented Jan 17, 2015

When React v0.13 comes out, just rename getDOMNode to React.findDOMNode(...)

See:
facebook/react#2802
facebook/react#2646

EDIT: nvm, didn't see the edit.

@zertosh zertosh deleted the snippets-fixes branch January 27, 2015 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants