Use es.* for stable esnext features
#98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
force-pushed
the
update-corejs3-definitions
branch
from
00d009b
to
5248a9d
Compare
|
Could we add a checker for es-shims also? |
JLHwung
force-pushed
the
update-corejs3-definitions
branch
from
5248a9d
to
8f1a95a
Compare
JLHwung
changed the title
es.* for stable esnext features
|
@ljharb Sure, will do it in a separate PR. |
zloirock
reviewed
Aug 25, 2021
1 task
JLHwung
commented
Aug 25, 2021
| @@ -128,7 +132,7 @@ _reduceRightInstanceProperty(object); | |||
|
|
|||
| _repeatInstanceProperty(object); | |||
|
|
|||
| object.replaceAll; | |||
There was a problem hiding this comment.
Since the replaceAll is stage 4, we should polyfill it if users are using an older version of corejs which provides esnext.string.replace-all.
zloirock
reviewed
Aug 25, 2021
| @@ -104,13 +107,31 @@ export default defineProvider<Options>(function( | |||
| !(object && desc.exclude && desc.exclude.includes(object)) && | |||
| esnextFallback(desc.name, shouldInjectPolyfill) | |||
| ) { | |||
| const { name } = desc; | |||
| let useProposalBase = false; | |||
| if (proposals || name.startsWith("es.next")) { | |||
JLHwung
commented
Aug 26, 2021
| @@ -109,7 +109,7 @@ export default defineProvider<Options>(function( | |||
| ) { | |||
| const { name } = desc; | |||
| let useProposalBase = false; | |||
| if (proposals) { | |||
| if (proposals || (shippedProposals && name.startsWith("esnext."))) { | |||
There was a problem hiding this comment.
name.startsWith("esnext.") is always false when both proposals and shippedProposals are not enabled.
nicolo-ribaudo
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97
Added a
builtin-definition-checkerso we don't forget to update it anymore.