Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update change babel-preset-es2015 to babel-preset-env #404

Merged
merged 3 commits into from
Mar 4, 2017
Merged

Update change babel-preset-es2015 to babel-preset-env #404

merged 3 commits into from
Mar 4, 2017

Conversation

JPeer264
Copy link
Contributor

@JPeer264 JPeer264 commented Mar 3, 2017 •
edited
Loading

Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
babel-preset-es2015 is used

What is the new behavior?
Changed to babel-preset-env in the readme and .babelrc

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

  • Impact:
  • Migration path for existing applications:
  • Github Issue(s) this is regarding:

Other information:

danez
danez suggested changes Mar 3, 2017
View reviewed changes
package.json Outdated
@@ -22,7 +22,7 @@
"babel-core": "^6.0.0",
"babel-eslint": "^7.1.0",
"babel-plugin-istanbul": "^3.0.0",
"babel-preset-es2015": "^6.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

babel-preset-es2015 is used in tests, so it needs to stay

.babelrc Outdated
@@ -1,6 +1,6 @@
{
"presets": [
["latest", { "es2015": { "loose": true } }]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is invalid, we use latest here no es2015

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, of course - thanks!

@codecov
Copy link

codecov bot commented Mar 3, 2017

Codecov Report

Merging #404 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #404   +/-   ##
=======================================
  Coverage   83.03%   83.03%           
=======================================
  Files           6        6           
  Lines         165      165           
  Branches       38       38           
=======================================
  Hits          137      137           
  Misses         12       12           
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 931c619...6bdbfb7. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 3, 2017 •
edited
Loading

Codecov Report

Merging #404 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #404   +/-   ##
=======================================
  Coverage   83.03%   83.03%           
=======================================
  Files           6        6           
  Lines         165      165           
  Branches       38       38           
=======================================
  Hits          137      137           
  Misses         12       12           
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 931c619...7ad5bf5. Read the comment docs.

@JPeer264
Copy link
Contributor Author

JPeer264 commented Mar 3, 2017

@danez should be valid now!

hzoo
hzoo reviewed Mar 4, 2017
View reviewed changes
package.json Outdated
@@ -22,7 +22,8 @@
"babel-core": "^6.0.0",
"babel-eslint": "^7.1.0",
"babel-plugin-istanbul": "^3.0.0",
"babel-preset-es2015": "^6.0.0",
"babel-preset-env": "^1.1.11",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to add this useless we're going to use it on babel-loader itself

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh true, I forgot to remove that! Thanks.

@danez
Copy link
Member

danez commented Mar 4, 2017 •
edited
Loading

I'm okay with it as is, but if you want you could replace preset-latest with preset-env in package.json and .babelrc.
https://twitter.com/left_pad/status/837757756748759040
Otherwise I merge it.

@hzoo hzoo merged commit 9ea739f into babel:master Mar 4, 2017
danez added a commit that referenced this pull request Mar 6, 2017
@danez
Merge branch 'master' into 7.0
70c8c4a 
* master:
  added metadata passing from babel to webpack (#398)
  document globalOptions (#365)
  Docs: change babel-preset-es2015 to babel-preset-env (#404) [skip ci]

# Conflicts:
#	README.md
#	package.json
#	src/index.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzoo hzoo hzoo left review comments

@danez danez danez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JPeer264 @danez @hzoo