Use valid instead of legal #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Legal makes it sounds like it's a legal issue, yet it's more about the validity of the value.
Current coverage is 94.63% (diff: 100%)
|
Ognian
pushed a commit
to Ognian/babel-loader
that referenced
this pull request
Feb 27, 2017
Legal makes it sounds like it's a legal issue, yet it's more about the validity of the value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
Current README implies name is a legal issue
What is the new behavior?
New README implies the name is valid option
Does this PR introduce a breaking change?
If this PR contains a breaking change, please describe the following...
Not relevant
Other information:
Legal makes it sounds like it's a legal issue, yet it's more about the validity of the value.