Skip to content

Commit

Permalink
Merge pull request #2 from babbel/fix-zone-id
Browse files Browse the repository at this point in the history
Fix zone_id, prepare v1.1.0
  • Loading branch information
awendt authored Jan 26, 2022
2 parents 4d508d4 + 414ca6e commit 5cff409
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 5 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## v1.1.0

- [Fix Zone ID](https://github.com/babbel/terraform-aws-ses-sending-domain/pull/2)

## v1.0.0

- [Initial version](https://github.com/babbel/terraform-aws-ses-sending-domain/pull/1)
2 changes: 1 addition & 1 deletion _test/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module "ses-sending-domain" {

domain_name = "example.com"
route53_zone = {
id = "123"
zone_id = "123"
}
sns_topic_name = "foo"
tags = {}
Expand Down
2 changes: 1 addition & 1 deletion dkim.tf
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ resource "aws_ses_domain_dkim" "this" {
resource "aws_route53_record" "domainkey_cname" {
count = 3

zone_id = var.route53_zone.id
zone_id = var.route53_zone.zone_id
name = "${aws_ses_domain_dkim.this.dkim_tokens[count.index]}._domainkey.${var.domain_name}."
type = "CNAME"
ttl = 3600
Expand Down
2 changes: 1 addition & 1 deletion ses.tf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ resource "aws_ses_domain_identity" "this" {
}

resource "aws_route53_record" "amazonses_txt" {
zone_id = var.route53_zone.id
zone_id = var.route53_zone.zone_id
name = "_amazonses.${var.domain_name}."
type = "TXT"
ttl = 600
Expand Down
2 changes: 1 addition & 1 deletion spf.tf
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
resource "aws_route53_record" "txt" {
zone_id = var.route53_zone.id
zone_id = var.route53_zone.zone_id
name = "${var.domain_name}."
type = "TXT"
ttl = 600
Expand Down
2 changes: 1 addition & 1 deletion variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ EOS
}

variable "route53_zone" {
type = object({ id = string })
type = object({ zone_id = string })

description = <<EOS
The Route53 hosted zone to which all DNS records shall be added.
Expand Down

0 comments on commit 5cff409

Please sign in to comment.