Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TypeScript type-aware linting compatibility by passing true to project instead of a relative path #22

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

mangs
Copy link
Contributor

@mangs mangs commented Oct 1, 2024

Pull Request Checklist

  • I have read the CONTRIBUTING document
  • Readme and changelog updates were made reflecting this PR's changes
  • Increase the project version number in package.json following Semantic Versioning

Changes Included

@mangs mangs requested a review from jduthon October 1, 2024 01:54
Copy link

@jduthon jduthon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one small recommendation based on the docs

@@ -1,7 +1,7 @@
{
"parser": "@typescript-eslint/parser",
"parserOptions": {
"project": ["./tsconfig.json"]
"project": true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc you linked mentions:

note
We now recommend using projectService instead of project for easier configuration and faster linting.

So maybe we can go for

Suggested change
"project": true
"projectService": true

Copy link
Contributor Author

@mangs mangs Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yea projectService is for version 8, I wanted to use that but we can't. We're stuck on version 7 for now, so we have to use project which is the best option available for that version.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah missed that sorry! Looking good tehn!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, I have a plan to get us on 8, but it's blocked on the eslint AirBNB packages updating their dependencies. It will coincide with ESLint v9 support too which is handy. I'm tracking it here: airbnb/javascript#2961

Copy link

@jduthon jduthon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

@mangs mangs merged commit a4b1df2 into babbel:main Oct 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants