Add eslint-plugin-perfectionist and eslint-plugin-react-perf to the base and /react configs, respectively
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangs
changed the title
eslint-plugin-react-perf to the /react config and all its dependent configseslint-plugin-perfectionist and eslint-plugin-react-perf to the base and /react configs, respectively
mangs
commented
Sep 14, 2024
| "perfectionist/sort-imports": [ | ||
| "error", | ||
| { | ||
| "environment": "bun", |
There was a problem hiding this comment.
environment switched to Bun so bun:* imports work (e.g. bun:test) without any more hacks (e.g. the settings: section that I removed in this PR)
Comment on lines
+43
to
+62
| "perfectionist/sort-imports": [ | ||
| "error", | ||
| { | ||
| "environment": "node", | ||
| "groups": [ | ||
| ["side-effect", "side-effect-style"], | ||
| ["builtin", "external"], | ||
| ["index", "internal", "parent", "sibling", "unknown"], | ||
| ["type"], | ||
| ["object"] | ||
| ], | ||
| "newlines-between": "always" | ||
| "object", | ||
| [ | ||
| "builtin-type", | ||
| "external-type", | ||
| "index-type", | ||
| "internal-type", | ||
| "parent-type", | ||
| "sibling-type", | ||
| "type" | ||
| ], | ||
| "style" | ||
| ] |
There was a problem hiding this comment.
a huge upside to these are they are now auto-fixable with eslint-plugin-perfectionist, so you can fix your whole codebase with one command (e.g. eslint --fix)
| "extends": [ | ||
| "eslint-config-airbnb", | ||
| "airbnb/hooks", | ||
| "plugin:jsx-a11y/recommended", | ||
| "plugin:react-perf/recommended", |
There was a problem hiding this comment.
nice performance recommendations here for React apps
mangs
commented
Sep 14, 2024
mangs
commented
Sep 16, 2024
| @@ -192,26 +192,26 @@ export { | |||
| anError, | |||
There was a problem hiding this comment.
text fixes from here down
jduthon
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
package.jsonfollowing Semantic VersioningChanges Included
2.1.0eslint-plugin-perfectionistto the base configuration and all its dependent configurationsimport/order,sort-keys, andsort-varseslint-plugin-react-perfto the/reactconfiguration and all its dependent configurations1.1.17to1.1.27