client - adding ability to include query string in request #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It’s ugly, but not against the specification. In an indirect, kind of heavily interpreted way, it’s explicitly allowed, see: http://xmlrpc.scripting.com/spec.html >The format of the URI in the first line of the header is not specified. This, as far as I can tell, indicates that it CAN include query strings. Tests are included.
|
Let me know if there's anything else you need me to add. I'd like to get this into npm soon, I need it in production. |
|
Any chance this will ever get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It’s ugly, but not against the specification. In an indirect, kind of heavily interpreted way, it’s explicitly allowed, see:
http://xmlrpc.scripting.com/spec.html
This, as far as I can tell, indicates that it CAN include query strings.
Tests are included.