Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TI Project requirements #1

Merged
merged 6 commits into from
Oct 22, 2023
Merged

TI Project requirements #1

merged 6 commits into from
Oct 22, 2023

Conversation

SergejMuhic
Copy link

@SergejMuhic SergejMuhic commented May 10, 2023 •
edited
Loading

  1. created Project root with requirements

EDIT: Please review the entire file since there was a baseline committed beforehand.

@SergejMuhic SergejMuhic requested review from larswik and pjanck May 10, 2023 19:43
@SergejMuhic SergejMuhic self-assigned this May 10, 2023
pjanck
pjanck requested changes May 15, 2023
View reviewed changes
Copy link
Member

@pjanck pjanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only read through the xml code and did not load this in any UI.

IFC4x3/ModelViews/TI-Bridge/DocModelView.xml Outdated Show resolved Hide resolved
IFC4x3/ModelViews/TI-Bridge/DocModelView.xml Outdated Show resolved Hide resolved
IFC4x3/ModelViews/TI-Bridge/DocModelView.xml Outdated Show resolved Hide resolved
IFC4x3/ModelViews/TI-Bridge/DocModelView.xml Show resolved Hide resolved
@pjanck pjanck self-requested a review May 15, 2023 15:04
pjanck
pjanck reviewed May 21, 2023
View reviewed changes
Copy link
Member

@pjanck pjanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the last two commits only. I still need to go through the whole content as indicated in the PR's description.

@pjanck pjanck mentioned this pull request Jun 5, 2023
Open
pjanck
pjanck requested changes Jun 6, 2023
View reviewed changes
Copy link
Member

@pjanck pjanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using mvdXML Grammar to define rules, not the encoding in the reviewed file:

IFC4x3/ModelViews/TI-Bridge/DocModelView.xml Outdated Show resolved Hide resolved
pjanck
pjanck requested changes Jun 6, 2023
View reviewed changes
Copy link
Member

@pjanck pjanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goes with previous review (forgot to submit ...).

IFC4x3/ModelViews/TI-Bridge/DocModelView.xml Outdated Show resolved Hide resolved
pjanck
pjanck approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@pjanck pjanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM

Very neat solution, adding the SIPrefix RuleID!

@pjanck pjanck self-requested a review October 17, 2023 15:42
@pjanck pjanck mentioned this pull request Oct 17, 2023
Merged
@SergejMuhic SergejMuhic merged commit 062552b into bridge Oct 22, 2023
@SergejMuhic SergejMuhic deleted the TI/Project branch October 22, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larswik larswik larswik approved these changes

@pjanck pjanck pjanck approved these changes

Assignees

@SergejMuhic SergejMuhic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SergejMuhic @larswik @pjanck