Add nested context descriptions to lock documents #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking the item at the end of the list should be as efficient as inspecting the head of a queue.
...creating a new version
Also add a comment on how it is supposed to work.
…hen..." This reverts commit 8dfd645.
...RepositoryTransactionContext (so no unlock is attempted on a lock that was not granted)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 9.x #1353 +/- ##
============================================
- Coverage 64.11% 64.10% -0.01%
- Complexity 12619 12626 +7
============================================
Files 1614 1614
Lines 57269 57333 +64
Branches 5633 5637 +4
============================================
+ Hits 36717 36756 +39
- Misses 18195 18233 +38
+ Partials 2357 2344 -13 ☔ View full report in Codecov by Sentry. |
...anticipation of ImportRequest taking a lock with the same description before the first commit takes place
nagyo
approved these changes
Dec 9, 2024
...m.b2international.snowowl.core/src/com/b2international/snowowl/core/locks/OperationLock.java
Show resolved
Hide resolved
cmark
requested changes
Dec 9, 2024
...ational.snowowl.core/src/com/b2international/snowowl/core/locks/DatastoreLockIndexEntry.java
Show resolved
Hide resolved
...from older indices if for any reason a lock entry gets stuck
cmark
approved these changes
Dec 9, 2024
apeteri
commented
Dec 9, 2024
| @JsonSetter | ||
| Builder parentDescription(final String parentDescription) { | ||
| // lock documents with a parentDescription value should propagate their values to contexts | ||
| addContext(parentDescription); |
There was a problem hiding this comment.
parentDescription goes first in the list, so a contexts.add(0, parentDescription) equivalent could be used here. Although whether this is required or not will also depend on the order of the two setter calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to track re-entrant locks that go more than two levels deep.