Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snomed.datastore): Flush pending expand requests in request cache... #1351

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

apeteri
Copy link
Member

@apeteri apeteri commented Dec 2, 2024

...when exporting content to DSV; otherwise the nested expansion for relationship destination PTs is deferred until the export finishes, which is of no use at that point.

...when exporting content to DSV; otherwise the nested expansion for
relationship destination PTs is deferred until the export finishes,
which is of no use at that point.
@apeteri apeteri added the bug label Dec 2, 2024
@apeteri apeteri requested review from cmark and nagyo December 2, 2024 17:42
@apeteri apeteri self-assigned this Dec 2, 2024
Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥓

Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.11%. Comparing base (9ef4e8e) to head (1523345).
Report is 3 commits behind head on 9.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                9.x    #1351      +/-   ##
============================================
- Coverage     64.11%   64.11%   -0.01%     
  Complexity    12619    12619              
============================================
  Files          1614     1614              
  Lines         57266    57269       +3     
  Branches       5633     5633              
============================================
  Hits          36716    36716              
- Misses        18194    18196       +2     
- Partials       2356     2357       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmark cmark merged commit 67682e6 into 9.x Dec 3, 2024
5 checks passed
@cmark cmark deleted the issue/SO-6321-flush-cached-expand-requests branch December 3, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants