Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parallel checktx #367

Merged
merged 7 commits into from
Jan 15, 2025
Merged

Conversation

dudong2
Copy link

@dudong2 dudong2 commented Dec 15, 2024

Description

Applied prs

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dudong2 dudong2 self-assigned this Dec 15, 2024
Copy link

@dudong2 your pull request is missing a changelog!

@dudong2 dudong2 changed the title feat: concurrent rechecktx feat: parallel rechecktx Dec 15, 2024
@dudong2 dudong2 changed the title feat: parallel rechecktx feat: parallel checktx Dec 15, 2024
@dudong2 dudong2 changed the base branch from basechain/develop-v0.50.8 to basechain/develop-v0.50.11 December 17, 2024 10:19
@dudong2 dudong2 changed the base branch from basechain/develop-v0.50.11 to feat/v0.50.11-bump December 17, 2024 10:33
@dudong2 dudong2 force-pushed the feat/parallel-checktx branch from 4f14f47 to 7a05e02 Compare December 17, 2024 10:37
@dudong2 dudong2 changed the base branch from feat/v0.50.11-bump to basechain/develop-v0.50.11 December 19, 2024 05:45
@dudong2 dudong2 force-pushed the feat/parallel-checktx branch from 15d8c40 to 5ec7fc9 Compare December 19, 2024 05:51
Copy link

@zsystm zsystm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dudong2
Overall LGTM. Could you add some kind comments for newly introduced codes.

@dudong2 dudong2 requested a review from zsystm January 12, 2025 20:03
Copy link

@zsystm zsystm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are based solely on code review; no tests have been conducted for this PR yet. Additional comments may follow after testing.

@dudong2 dudong2 requested a review from zsystm January 14, 2025 15:15
@dudong2 dudong2 requested a review from jasonsong0 January 15, 2025 04:35
Copy link

@jasonsong0 jasonsong0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 merged commit 3c1f7a0 into basechain/develop-v0.50.11 Jan 15, 2025
38 of 47 checks passed
@dudong2 dudong2 deleted the feat/parallel-checktx branch January 15, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants