Feat: tx rate limit #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: need to add error to cosmos-sdk after merge.(like ErrMempoolIsFull) |
@dudong2 |
|
Yes, need to register an error in the cosmos-sdk to check that a comet-related error occurred at the broadcast tx level. |
cloudgray
reviewed
Jan 17, 2025
mempool/errors.go
Outdated
| } | ||
|
|
||
| func (e ErrMempoolRateLimitExceeded) Error() string { | ||
| return fmt.Sprintf("mempool rate limit exceeded: rate %d, count %d", e.Rate, e.Count) |
There was a problem hiding this comment.
I think rate: %d is little bit obvious.
How about rate: "%d txs per block?
dudong2
added a commit
that referenced
this pull request
Feb 18, 2025
* feat: Rate limit * chore: Change default valuetest: Fix tests * chore: Change default value to -1 * test: Add mock func for ResetRateLimitCounter * chore: Rate -> Limit
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref. a81c3c7
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments