Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when editing properties in Node Editor #1139

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

yuto-trd
Copy link
Member

Description

This fix addresses a System.InvalidOperationException that occurred in the Node Editor when editing properties. The crash was due to a failure in retrieving a required service in the SetValue method of BaseEditorViewModel. The update ensures that services are correctly initialized and accessible during property editing, preventing the application from crashing when properties are modified.

Breaking changes

Fixed issues

Copy link
Contributor

No TODO comments were found.

Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Complexity Health
Beutl.ProjectSystem 13% 7% 2182
Beutl.Utilities 73% 67% 360
Beutl.Threading 100% 92% 118
Beutl.Operators 4% 0% 62
Beutl.Engine 25% 24% 8897
Beutl.Core 33% 31% 3120
Beutl.Extensibility 2% 0% 66
Beutl.Configuration 39% 19% 285
Beutl.Language 0% 0% 650
Summary 25% (9300 / 37311) 25% (2660 / 10833) 15740

Minimum allowed line rate is 0%

@yuto-trd yuto-trd merged commit a44bbb4 into main Oct 29, 2024
4 checks passed
@yuto-trd yuto-trd deleted the fix/node-editor branch October 29, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant