Config file update #224
Merged
Config file update #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I had to force push the branch (error on my side), can you rebase it ? |
Changes to comments for setting: 'SIZE=128M'
Changes to comments for setting: 'USE_RSYNC=false'
Changes to comments for setting: 'NOTIFICATION=true'
Changes to comments for setting: 'NOTIFICATION_COMMAND='
Changes to comments for setting: 'PATH_DISK='
Changes to comments for setting: 'JOURNALD_AWARE='
Changes to comments for setting: 'ZL2R='
Changes to comments for setting: 'COMP_ALG='
Update to comment for setting: 'LOG_DISK_SIZE='
Update to comment for setting: 'ZL2R='
Update to comment for setting: 'SIZE='
adamsthws
force-pushed
the
config-file-update
branch
from
ecb8ebb to
136d2c1
Compare
Yes Sir, no problem! |
XhmikosR
reviewed
Jun 28, 2024
| # Note: 'rsync' must be used for this feature. | ||
| # Ensure 'SystemMaxUse' is configured in 'journald.conf' | ||
| # - (To limit journald’s disk usage to be smaller than the log2ram RAM allocation). | ||
| JOURNALD_AWARE=true |
There was a problem hiding this comment.
Isn't this block duplicated with line 35?
There was a problem hiding this comment.
Yes, thankyou for catching this! It has now been fixed in: this commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance Clarity and Readability of Configuration Comments
Overview
This pull request introduces a series of comment updates in the configuration files to improve clarity and readability.
By enhancing the documentation directly within the configuration files, we can reduce the learning curve and help prevent configuration errors.
The changes should make it easier to setup log2ram, especially for new users or those not familiar with the more technical aspects of system configuration.
The revisions provide concise, clear explanations of configuration settings. This includes specifying the purpose and implications of each setting, offering examples where applicable, and outlining the effects of different configurations on system behavior.
Thankyou,
Adam