Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rsync and fuzzy param #92

Closed
TookaFace opened this issue Sep 18, 2019 · 6 comments
Closed

Rsync and fuzzy param #92

TookaFace opened this issue Sep 18, 2019 · 6 comments
Assignees
Labels

Comments

@TookaFace
Copy link

Hi, with new version and new param for rsync, i have a problem.

If i create a file, for example, /var/log/foe.log, and reboot, then the file is no longer here with rsync set to true.

If i use cp then file is here at reboot.

I ran some tests, and without fuzzy param, it work, file is here at reboot.

@azlux azlux added the bug label Sep 19, 2019
@azlux
Copy link
Owner

azlux commented Sep 19, 2019

Hi,
I didn't see this behavior. Sorry for the inconvenient.

Is the file present into /var/hdd.log/foe.log ?

what is your rsync --version ?

Az

@azlux
Copy link
Owner

azlux commented Sep 19, 2019

Ok, I see the issue.
it's appear when you hit race condition.
It's a conflict between --append and --fuzzy. Append will avoid fuzzy to do is job on smaller file than destination.

@azlux azlux self-assigned this Sep 19, 2019
@TookaFace
Copy link
Author

Ok, my rsync version is 3.1.2 protocol version 31.

@azlux
Copy link
Owner

azlux commented Sep 19, 2019

Can you replace
rsync -aXWv --fuzzy --no-whole-file --append --delete-after --links
by
rsync -aXv --inplace --no-whole-file --delete-after

On the file /usr/local/bin/log2ram (2 places on the file. L21 and L41).
It's should be better.

@TookaFace
Copy link
Author

That seems to work, thank you

azlux pushed a commit that referenced this issue Sep 20, 2019
fix for #92 , bad fuzzy parameter
@azlux azlux closed this as completed Sep 20, 2019
@azlux
Copy link
Owner

azlux commented Sep 20, 2019

New release with the fix. Thank for the report.
https://github.com/azlux/log2ram/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants