Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use non-empty-string annoation #162

Merged
merged 3 commits into from
Mar 24, 2021
Merged

use non-empty-string annoation #162

merged 3 commits into from
Mar 24, 2021

Conversation

ntzm
Copy link
Contributor

@ntzm ntzm commented Mar 23, 2021

No description provided.

@coveralls
Copy link

coveralls commented Mar 23, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 683028960

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 682372996: 0.0%
Covered Lines: 2916
Relevant Lines: 2916
💛 - Coveralls

@azjezz
Copy link
Owner

azjezz commented Mar 23, 2021

psalm failure seems unrelated, will fix that in a few, can you please regenerate the documentation ( php docs/documenter.php ) to update the link to the function declaration?

@azjezz azjezz added this to the 1.6.0 milestone Mar 23, 2021
@azjezz azjezz added Priority: Medium This issue may be useful, and needs some attention. Status: Revision Needed At least two people have seen issues in the PR that makes them uneasy. Type: Enhancement Most issues will probably ask for additions or changes. labels Mar 23, 2021
@azjezz
Copy link
Owner

azjezz commented Mar 23, 2021

psalm issues have been fixed in 1.6.x, please rebase.

@azjezz azjezz added Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. and removed Status: Revision Needed At least two people have seen issues in the PR that makes them uneasy. labels Mar 24, 2021
@azjezz azjezz merged commit 9b1a24e into azjezz:1.6.x Mar 24, 2021
@azjezz azjezz added Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness and removed Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. labels Mar 24, 2021
@azjezz
Copy link
Owner

azjezz commented Mar 24, 2021

Thank you @ntzm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azjezz azjezz azjezz approved these changes

Assignees

@ntzm ntzm

@azjezz azjezz

Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ntzm @coveralls @azjezz