Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(script/timing)Change Nalorakk's abilities timing. #20682

Closed

Conversation

Rorschach91
Copy link
Member

@Rorschach91 Rorschach91 commented Nov 22, 2024

Timing changes.

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

Timing changes.
@github-actions github-actions bot added Script file-cpp Used to trigger the matrix build labels Nov 22, 2024
@Rorschach91 Rorschach91 requested a review from Nyeriah November 22, 2024 11:20
@Nyeriah
Copy link
Member

Nyeriah commented Nov 22, 2024

How did you get those timers?

@Rorschach91
Copy link
Member Author

Rorschach91 commented Nov 22, 2024

How did you get those timers?

I forgot to convert this PR to draft.
They are the timers of the report. These timers are only what is closest to the original timers (looking the videos from the official servers, making a few of calculations), but it could be better if a sniff exist.

@Rorschach91 Rorschach91 marked this pull request as draft November 22, 2024 12:57
@Rorschach91 Rorschach91 added the Needs sniff The issue/PR needs sniff data to be corrected. label Dec 14, 2024
@Rorschach91 Rorschach91 marked this pull request as ready for review December 14, 2024 19:55
@amed80
Copy link
Contributor

amed80 commented Dec 15, 2024

Could the timers for bear form also be changed for the first cast similar to the recast ?
Lacerating Slash should have interval of 04-26s
Rend Flesh should have interval of 06-21s
Deafening Roar should have interval of 11-24s

@Rorschach91 Rorschach91 deleted the Nalorakk_spell_timing branch December 15, 2024 22:46
@Rorschach91
Copy link
Member Author

Could the timers for bear form also be changed for the first cast similar to the recast ? Lacerating Slash should have interval of 04-26s Rend Flesh should have interval of 06-21s Deafening Roar should have interval of 11-24s

I will do it again tomorrow when I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file-cpp Used to trigger the matrix build Needs sniff The issue/PR needs sniff data to be corrected. Script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Zul'Aman] Nalorakk's abilties have wrong timers [Zul'Aman] Nalorakk's abilties have wrong timers
3 participants