fix(Core/Player): Quest failure sound when inventory full (#20970)

* Add quest failure sound when inventory is full or quest failed * Fix sound being played for all players & move call to correct function
azerothcore · Dec 19, 2024 · 4d1dba4 · 4d1dba4
1 parent a23b13d
commit 4d1dba4
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/src/server/game/Entities/Player/PlayerQuest.cpp b/src/server/game/Entities/Player/PlayerQuest.cpp
@@ -279,6 +279,7 @@ bool Player::CanAddQuest(Quest const* quest, bool msg)
         else if (msg2 != EQUIP_ERR_OK)
         {
             SendEquipError(msg2, nullptr, nullptr, srcitem);
+            PlayDirectSound(QUEST_SOUND_FAILURE, this); // Play failure sound
             return false;
         }
     }

diff --git a/src/server/game/Entities/Player/PlayerStorage.cpp b/src/server/game/Entities/Player/PlayerStorage.cpp
@@ -4059,7 +4059,6 @@ void Player::SendEquipError(InventoryResult msg, Item* pItem, Item* pItem2, uint
         }
     }
     GetSession()->SendPacket(&data);
-    PlayDirectSound(QUEST_SOUND_FAILURE); // Play failure sound
 }
 
 void Player::SendBuyError(BuyResult msg, Creature* creature, uint32 item, uint32 param)
-Original file line number
+Diff line change
@@ Expand Up @@
             }
         }
         GetSession()->SendPacket(&data);
-        PlayDirectSound(QUEST_SOUND_FAILURE); // Play failure sound
     }
     void Player::SendBuyError(BuyResult msg, Creature* creature, uint32 item, uint32 param)
@@ Expand Down @@