Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve error when task network mode is not awsvpc #35

Closed
wants to merge 1 commit into from

Conversation

KlaasH
Copy link

@KlaasH KlaasH commented Mar 11, 2024

Overview

This is a change that Rocky made in 2021 and we've been using the branch in MUB's requirements file ever since. His commit message:

When a task's network mode is not awsvpc (e.g., when we're using a traditional ECS cluster), the payload from describe_task_definition doesn't have the networkMode key.

I don't know for sure that that's even still true, though my guess would be that the API for old-style ECS clusters hasn't changed. I also haven't tested this change in any way, except to the extent that it's been in use on MUB.

But given that it seems mathematically impossible that substituting "check for the key, then look it up" for "just look it up" would cause problems, that seems OK to me.

When a task's network mode is not awsvpc (e.g., when we're using a traditional
ECS cluster), the payload from describe_task_definition doesn't have the
networkMode key.
@KlaasH
Copy link
Author

KlaasH commented Mar 11, 2024

Nevermind, I must have been looking at an old version of ecsmanage.py without realizing it. #33 fixed this already.

@KlaasH KlaasH closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants