Resolve error when task network mode is not awsvpc #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a change that Rocky made in 2021 and we've been using the branch in MUB's requirements file ever since. His commit message:
I don't know for sure that that's even still true, though my guess would be that the API for old-style ECS clusters hasn't changed. I also haven't tested this change in any way, except to the extent that it's been in use on MUB.
But given that it seems mathematically impossible that substituting "check for the key, then look it up" for "just look it up" would cause problems, that seems OK to me.