Feature/tnation/docker py

[tnation14]

Install the Docker SDK instead of docker-py. Also, bump ansible-pip role version and update the example installation to be compatible with the new version of docker.

Fixes #11

Testing

$ cd examples
examples/ $ vagrant up --provision
$ vagrant ssh -c "docker ps"

[hectcastro]

Since this is going to break backwards compatibility anyway (major revision bump), I think that it makes sense to rename docker_py_version to something like docker_python_sdk_version or something like that.

[hectcastro]

Is there a reason this was taken out? I agree that it probably has little value, but given that, it at least exercises the interaction between Ansible and the Docker Engine (which happens via the Docker for Python SDK).

[tnation14]

I took it out because the Ansible docker module is deprecated. Additionally, when I was researching the replacement, docker_container, the requirements indicated that the interaction between Ansible and the Docker API are still taking place via the old docker-py module. It wasn't testing the current docker SDK installation anymore. I've updated this task to run a docker command on the VM using Ansible command, which does require the docker SDK to work properly.

[tnation14]

Updated.

[hectcastro]

Ugh, I think I made a mistake in the assembly of the issue that led to this PR.

I thought that swapping docker-py for docker (the Docker for Python SDK) would work based on ansible/ansible@e2a1ce2, but now I'm realizing that it won't work until Ansible 2.3.

The main goal here is to install Docker via Ansible so that it works for the follow two cases:

• Setups that make use of the docker and docker_container Ansible modules (requires docker-py, and in Ansible 2.3, docker-py or docker)
• Setups that expect to be able to install modern versions of Docker Compose (but run into problems due to namespace collisions with docker-py; AttributeError: 'module' object has no attribute 'get_config_header' after upgrading to 1.10 docker/compose#4344)

Perhaps the right move here is to remove the docker-py or docker Python module installation altogether, push the responsibility of installing it to the user (if they want to use the Ansible modules), and increment the major version of this role.

[tnation14]

Updated, the docker module has been removed.

[hectcastro]

👍

Sorry for the confusion around this issue. Please ensure that we bump the major version of this on release too.