Skip to content
This repository has been archived by the owner on Aug 31, 2018. It is now read-only.

Commit

Permalink
[squash] nits
Browse files Browse the repository at this point in the history
  • Loading branch information
addaleax committed Oct 14, 2017
1 parent d9b49b7 commit 582b756
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
8 changes: 4 additions & 4 deletions lib/internal/worker.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ util.inherits(MessagePort, EventEmitter);

const debug = util.debuglog('worker');

// A MessagePort consists a handle (that wraps around an
// A MessagePort consists of a handle (that wraps around an
// uv_async_t) which can receive information from other threads and emits
// .onmessage events, and a function used for sending data to a MessagePort
// in some other thread.
Expand All @@ -22,7 +22,7 @@ function onmessage(payload, flag) {
}

Object.defineProperty(MessagePort.prototype, 'onmessage', {
enumerable: false,
enumerable: true,
configurable: true,
get() { return onmessage; },
set(value) {
Expand All @@ -42,7 +42,7 @@ function oninit() {
}

Object.defineProperty(MessagePort.prototype, 'oninit', {
enumerable: false,
enumerable: true,
writable: false,
value: oninit
});
Expand All @@ -52,7 +52,7 @@ function onclose() {
}

Object.defineProperty(MessagePort.prototype, 'onclose', {
enumerable: false,
enumerable: true,
writable: false,
value: onclose
});
Expand Down
1 change: 0 additions & 1 deletion src/env.h
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,6 @@ class ModuleWrap;
V(promise_wrap_template, v8::ObjectTemplate) \
V(push_values_to_array_function, v8::Function) \
V(randombytes_constructor_template, v8::ObjectTemplate) \
V(sab_lifetimepartner_constructor_template, v8::FunctionTemplate) \
V(script_context_constructor_template, v8::FunctionTemplate) \
V(script_data_constructor_function, v8::Function) \
V(secure_context_constructor_template, v8::FunctionTemplate) \
Expand Down
3 changes: 1 addition & 2 deletions src/node_messaging.cc
Original file line number Diff line number Diff line change
Expand Up @@ -519,8 +519,7 @@ MaybeLocal<Function> GetMessagePortConstructor(
Environment* env, Local<Context> context) {
// Factor generating the MessagePort JS constructor into its own piece
// of code, because it is needed early on in the child environment setup.
Local<FunctionTemplate> templ;
templ = env->message_port_constructor_template();
Local<FunctionTemplate> templ = env->message_port_constructor_template();
if (!templ.IsEmpty())
return templ->GetFunction(context);

Expand Down

0 comments on commit 582b756

Please sign in to comment.