Skip to content
This repository has been archived by the owner on Jul 24, 2018. It is now read-only.

tweak to iterator Seek(Slice.BeforeAllKeys) + some commits that accumulated on my branch #12

Open
wants to merge 12 commits into
base: voron
Choose a base branch
from

Conversation

myarichuk
Copy link
Collaborator

  • the tweak on iterator's seek is this commit -> myarichuk@01662db
    what I think that if RequiredPrefix is set - it is kind of "filter" that lets you iterate on only relevant keys, and this tweak makes seeks to begin and end more intuitive
    Thats the main reason for this PR
  • some commits seems to have accumulated on my branch of Voron, and I think it would be good to check if no code that should be in Voron was left out by accident

ppekrol and others added 10 commits February 17, 2014 15:09
1)fix for RavenDB-1740
2)added credentials when ReplicationInformer::RefreshReplicationInformation() is called
3)fix after bad merge for WriteBatch.cs
Conflicts:
	Raven.Voron/Voron.Tryout/Properties/AssemblyInfo.cs
	Raven.Voron/Voron/Impl/Journal/WriteAheadJournal.cs
	Raven.Voron/Voron/StorageEnvironment.cs
…ve that Seek with Slice.BeforeAllKeys should set iterator to the first key with the if it is indeed found prefix.
@ayende
Copy link
Owner

ayende commented May 16, 2014

Michael,
We are currently doing all the Voron work in the RavenDB source repos.
Please send those changes there.

Oren Eini

CEO

Mobile: + 972-52-548-6969

Office: + 972-4-622-7811

Fax: + 972-153-4622-7811

On Fri, May 16, 2014 at 4:02 PM, Michael Yarichuk
notifications@github.comwrote:

the tweak on iterator's seek is this commit -> myarichuk@01662dbhttps://github.com/myarichuk/raven.voron/commit/01662db819d7292903ccdfe095551c4d0c9c2fd7
what I think that if RequiredPrefix is set - it is kind of "filter"
that lets you iterate on only relevant keys, and this tweak makes seeks to
begin and end more intuitive
Thats the main reason for this PR

some commits seems to have accumulated on my branch of Voron, and I
think it would be good to check if no code that should be in Voron was left
out by accident


You can merge this Pull Request by running

git pull https://github.com/myarichuk/raven.voron voron

Or view, comment on, or merge it at:

#12
Commit Summary

  • RavenDB-1735. Voron: Implement
    TramsactionalStorage.GetDatabaseSizeInBytes
  • the following changes included:
  • Merge branch 'New3' of github.com:ayende/ravendb into New3
  • RavenDB-1717. Voron: Add temp path option
  • Merge branch 'New3' of https://github.com/ayende/ravendb into
    RavenDB-1717
  • fixes for RavenDB-1745
  • Merge commit 'bf2d5c5ea236e5bda2f6ffd04140303776c4311e' into New3
  • taking remote changes - conflict resolution
  • when using TreeIterator, and the RequiredPrefix is set, it is
    intuitive that Seek with Slice.BeforeAllKeys should set iterator to the
    first key with the if it is indeed found prefix.
  • Merge branch 'voron' of https://github.com/myarichuk/raven.voroninto voron

File Changes

Patch Links:


Reply to this email directly or view it on GitHubhttps://github.com//pull/12
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants