This repository has been archived by the owner on Jul 24, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
tweak to iterator Seek(Slice.BeforeAllKeys) + some commits that accumulated on my branch #12
Open
myarichuk
wants to merge
12
commits into
ayende:voron
Choose a base branch
from
myarichuk:voron
base: voron
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1)fix for RavenDB-1740 2)added credentials when ReplicationInformer::RefreshReplicationInformation() is called 3)fix after bad merge for WriteBatch.cs
Conflicts: Raven.Voron/Voron.Tryout/Properties/AssemblyInfo.cs Raven.Voron/Voron/Impl/Journal/WriteAheadJournal.cs Raven.Voron/Voron/StorageEnvironment.cs
…ve that Seek with Slice.BeforeAllKeys should set iterator to the first key with the if it is indeed found prefix.
Michael, Oren Eini CEO Mobile: + 972-52-548-6969 Office: + 972-4-622-7811 Fax: + 972-153-4622-7811 On Fri, May 16, 2014 at 4:02 PM, Michael Yarichuk
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what I think that if RequiredPrefix is set - it is kind of "filter" that lets you iterate on only relevant keys, and this tweak makes seeks to begin and end more intuitive
Thats the main reason for this PR