Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests #87

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Tests #87

merged 1 commit into from
Mar 3, 2025

Conversation

ayasyrev
Copy link
Owner

@ayasyrev ayasyrev commented Mar 3, 2025

No description provided.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ayasyrev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request updates the project to include support for Python 3.13. It modifies the noxfile.py, noxfile_conda.py, noxfile_conda_lint.py, and noxfile_lint.py files to include Python 3.13 in the test matrix. It also updates the setup.cfg file to include Python 3.13 as a supported language. Additionally, it updates the version in src/nbmetaclean/version.py to 0.1.4_dev and fixes a type hint in tests/test_app_clean.py. Finally, it corrects some relative imports in src/nbmetaclean/check.py, src/nbmetaclean/clean.py, and src/nbmetaclean/helpers.py.

Highlights

  • Python 3.13 Support: The primary change is the addition of Python 3.13 to the testing and packaging configuration, ensuring compatibility and testing across the latest Python version.
  • Version Bump: The version number has been bumped to 0.1.4_dev, indicating a development release with new features or updates.
  • Type Hint Fix: A minor fix was applied to the run_app function in tests/test_app_clean.py to correctly handle default arguments.
  • Relative Imports: Relative imports were corrected in src/nbmetaclean/check.py, src/nbmetaclean/clean.py, and src/nbmetaclean/helpers.py.

Changelog

Click here to see the changelog
  • noxfile.py
    • Added Python 3.13 to the test matrix.
  • noxfile_conda.py
    • Added Python 3.13 to the conda test matrix.
  • noxfile_conda_lint.py
    • Added Python 3.13 to the conda lint matrix.
  • noxfile_lint.py
    • Added Python 3.13 to the lint matrix.
  • setup.cfg
    • Added Python 3.13 to the list of supported programming languages.
  • src/nbmetaclean/check.py
    • Corrected relative import for CodeCell and Nb.
  • src/nbmetaclean/clean.py
    • Corrected relative import for Cell, CodeCell, Metadata, Nb, and Output.
  • src/nbmetaclean/helpers.py
    • Corrected relative import for Nb and PathOrStr.
  • src/nbmetaclean/version.py
    • Updated version to 0.1.4_dev.
  • tests/test_app_clean.py
    • Fixed type hint for args in run_app function, providing a default value.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A new version is born,
With tests 'til the morn,
Python's latest embrace,
A faster, cleaner pace,
Bugs squashed, all forlorn.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the supported Python versions in the testing configuration and updates the project version. The changes look good overall.

Merge Readiness

The pull request is ready to be merged. The changes are straightforward and address the intended goal of updating the supported Python versions and project version. I am unable to approve the pull request in any circumstance, and users should have others review and approve this code before merging.

@ayasyrev ayasyrev changed the base branch from main to 0.1.4_dev March 3, 2025 07:30
@ayasyrev ayasyrev merged commit f0d382e into 0.1.4_dev Mar 3, 2025
@ayasyrev ayasyrev deleted the tests branch March 3, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant