Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate Unnecessary Shadow Warning #1264

Merged
merged 4 commits into from
Dec 31, 2024
Merged

Eliminate Unnecessary Shadow Warning #1264

merged 4 commits into from
Dec 31, 2024

Conversation

HoshinoTented
Copy link
Contributor

@HoshinoTented HoshinoTented commented Dec 29, 2024

This PR intends to eliminate unnecessary and annoying shadow warnings. However, the following code will not report any shadow warning even if the pattern shadows a local variable of another parameter:

def test (A : Type) (a : A) : A
| a, A => A

This is because we cannot tell the parameter of a pattern, this part is done in PatTycker, but it should can be done in desugarer.

@HoshinoTented HoshinoTented added this to the v0.37 milestone Dec 29, 2024
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.83%. Comparing base (5634d92) to head (c6d8826).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1264      +/-   ##
============================================
+ Coverage     82.81%   82.83%   +0.01%     
- Complexity     3986     3992       +6     
============================================
  Files           366      366              
  Lines         11755    11760       +5     
  Branches       1369     1369              
============================================
+ Hits           9735     9741       +6     
  Misses         1293     1293              
+ Partials        727      726       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ice1000 ice1000 enabled auto-merge December 31, 2024 02:45
@ice1000 ice1000 merged commit efb8707 into main Dec 31, 2024
4 checks passed
@ice1000 ice1000 deleted the elim-shadow branch December 31, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants