Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade TailwindCSS to version 4 #43

Merged
merged 28 commits into from
Feb 12, 2025
Merged

Conversation

landrade
Copy link
Contributor

This PR upgrades TailwindCSS to version 4, following the instructions from the official upgrade guide.

@axzilla
Copy link
Owner

axzilla commented Jan 29, 2025

Hey Leanardo,

thank you very much for taking your time to contribute. I really appreciate that! I'll leave some comments on some of your chnages. I'm happy to discuss more on that specific topic.

Thanks,
Axel

@axzilla
Copy link
Owner

axzilla commented Jan 29, 2025

I did a quick test, but it seems that class changes are not reflected in the CSS!

@landrade
Copy link
Contributor Author

I did a quick test, but it seems that class changes are not reflected in the CSS!

Hi @axzilla , I've just push the new version output.css. I didn't pay attention that needs to push the compiled version of css, but now it's ok =)

@axzilla
Copy link
Owner

axzilla commented Jan 30, 2025

Before we can merge this PR we have to fix the following:

zyriab and others added 23 commits February 7, 2025 21:46
Fix card component not compiling properly + docs inconsistencies
fix(button): small typo in state condition
…-in-sidebar

feat(docs): highlight current page in sidebar + add retry mechanism in `GenerateNonce`
@landrade landrade closed this Feb 11, 2025
@axzilla
Copy link
Owner

axzilla commented Feb 12, 2025

Why did you close this?

@landrade
Copy link
Contributor Author

It closed automatically because I did a push force =S

I'm working on it today. I will reopen when it done ;)

@landrade landrade reopened this Feb 12, 2025
@landrade landrade marked this pull request as draft February 12, 2025 05:25
@landrade
Copy link
Contributor Author

@axzilla I upgraded to Tailwind v4 using a CSS configuration file. I tested it on the docs page and everything appears to be working correctly. The installation guide has not been updated yet.

@landrade landrade marked this pull request as ready for review February 12, 2025 06:55
@axzilla axzilla changed the base branch from main to dev February 12, 2025 09:12
@axzilla axzilla merged commit 37d8f24 into axzilla:dev Feb 12, 2025
@axzilla
Copy link
Owner

axzilla commented Feb 12, 2025

Great job man! Thank you, I really appreciate it! This is definitely one step forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to TailwindCSS v4 does not work with standalone CLI
3 participants