Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Format.HasNested checks for existing Placeholder in Items #416

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

axunonb
Copy link
Member

@axunonb axunonb commented Jun 8, 2024

Closes #415

  • Format.HasNested checks Items for existing Placeholder
  • Update Format Class Initialization (mark overload with arg bool hasNested as obsolete

Closes  axuno#415
* `Format.HasNested` checks Items for existing `Placeholder`
* Update Format Class Initialization (mark overload with arg `bool hasNested` as obsolete
@axunonb axunonb requested a review from karljj1 June 8, 2024 21:09
Copy link

codecov bot commented Jun 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96%. Comparing base (cbb27ee) to head (88de66b).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #416   +/-   ##
===================================
- Coverage    96%    96%   -0%     
===================================
  Files        92     92           
  Lines      3230   3226    -4     
===================================
- Hits       3111   3107    -4     
  Misses      119    119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@axunonb axunonb merged commit e28d6a8 into axuno:main Jun 9, 2024
5 checks passed
@axunonb axunonb deleted the pr/format-hasnested branch June 9, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format.Items and Format.HasNested getting out-of-sync
2 participants