IVYPORTAL-17428 Check and remove deprecated features from portal - Co…

…de + Docs (#991) * Removed deprecated code * Renamed data class property iCase to caze to avoid warning * Removed warning releated to applicationHomeRef(), data class attribute start with Capital * Removed warning related to no explicit encoding in Designer * Replace xml namespace java.sun.com to xmlns.jcp.org
axonivy-market · Sep 5, 2024 · 9fe12cc · 9fe12cc
1 parent 8114583
commit 9fe12cc
Show file tree

Hide file tree

Showing 124 changed files with 180 additions and 848 deletions.
diff --git a/AxonIvyPortal/PortalKitTestHelper/.settings/org.eclipse.core.resources.prefs b/AxonIvyPortal/PortalKitTestHelper/.settings/org.eclipse.core.resources.prefs
@@ -0,0 +1,2 @@
+eclipse.preferences.version=1
+encoding/<project>=UTF-8
diff --git a/AxonIvyPortal/PortalKitTestHelper/pom.xml b/AxonIvyPortal/PortalKitTestHelper/pom.xml
@@ -9,6 +9,7 @@
   <properties>
     <ivy.engine.version>11.4.0</ivy.engine.version>
     <build.plugin.version>11.4.0-SNAPSHOT</build.plugin.version>
+    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
   </properties>
   <dependencies>
     <dependency>

diff --git a/AxonIvyPortal/PortalKitTestHelper/webContent/layouts/basic.xhtml b/AxonIvyPortal/PortalKitTestHelper/webContent/layouts/basic.xhtml
@@ -2,7 +2,7 @@
 <html xmlns="http://www.w3.org/1999/xhtml"
 	xmlns:f="http://xmlns.jcp.org/jsf/core"
 	xmlns:h="http://xmlns.jcp.org/jsf/html"
-	xmlns:c="http://java.sun.com/jsp/jstl/core"
+	xmlns:c="http://xmlns.jcp.org/jsp/jstl/core"
 	xmlns:ui="http://xmlns.jcp.org/jsf/facelets"
 	xmlns:ic="http://ivyteam.ch/jsf/component"
 	xmlns:p="http://primefaces.org/ui"

diff --git a/AxonIvyPortal/PortalKitTestHelper/webContent/layouts/includes/LeftMenu.xhtml b/AxonIvyPortal/PortalKitTestHelper/webContent/layouts/includes/LeftMenu.xhtml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
 <html xmlns="http://www.w3.org/1999/xhtml"
-	xmlns:c="http://java.sun.com/jsp/jstl/core"
+	xmlns:c="http://xmlns.jcp.org/jsp/jstl/core"
 	xmlns:f="http://xmlns.jcp.org/jsf/core"
 	xmlns:h="http://xmlns.jcp.org/jsf/html"
 	xmlns:ui="http://xmlns.jcp.org/jsf/facelets"

diff --git a/AxonIvyPortal/PortalKitTestHelper/webContent/layouts/includes/header.xhtml b/AxonIvyPortal/PortalKitTestHelper/webContent/layouts/includes/header.xhtml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
 <html xmlns="http://www.w3.org/1999/xhtml"
-	xmlns:c="http://java.sun.com/jsp/jstl/core"
+	xmlns:c="http://xmlns.jcp.org/jsp/jstl/core"
 	xmlns:f="http://xmlns.jcp.org/jsf/core"
 	xmlns:h="http://xmlns.jcp.org/jsf/html"
 	xmlns:ui="http://xmlns.jcp.org/jsf/facelets"

diff --git a/AxonIvyPortal/PortalKitTestHelper/webContent/layouts/includes/progress-loader.xhtml b/AxonIvyPortal/PortalKitTestHelper/webContent/layouts/includes/progress-loader.xhtml
@@ -1,5 +1,6 @@
-<ui:composition xmlns="http://www.w3.org/1999/xhtml" xmlns:f="http://java.sun.com/jsf/core" xmlns:h="http://java.sun.com/jsf/html"
-  xmlns:ui="http://java.sun.com/jsf/facelets" xmlns:p="http://primefaces.org/ui" xmlns:pa="http://primefaces.org/serenity">
+<ui:composition xmlns="http://www.w3.org/1999/xhtml" xmlns:f="http://xmlns.jcp.org/jsf/core"
+  xmlns:h="http://xmlns.jcp.org/jsf/html" xmlns:ui="http://xmlns.jcp.org/jsf/facelets"
+  xmlns:p="http://primefaces.org/ui" xmlns:pa="http://primefaces.org/serenity">
 
   <p:ajaxStatus id="ajaxLoadingStatus">
     <f:facet name="start">

diff --git a/AxonIvyPortal/PortalKitTestHelper/webContent/layouts/processChain.xhtml b/AxonIvyPortal/PortalKitTestHelper/webContent/layouts/processChain.xhtml
@@ -2,7 +2,7 @@
 <html xmlns="http://www.w3.org/1999/xhtml"
   xmlns:f="http://xmlns.jcp.org/jsf/core"
   xmlns:h="http://xmlns.jcp.org/jsf/html"
-  xmlns:c="http://java.sun.com/jsp/jstl/core"
+  xmlns:c="http://xmlns.jcp.org/jsp/jstl/core"
   xmlns:ui="http://xmlns.jcp.org/jsf/facelets"
   xmlns:ic="http://ivyteam.ch/jsf/component"
   xmlns:p="http://primefaces.org/ui"

diff --git a/AxonIvyPortal/portal-components/.settings/org.eclipse.core.resources.prefs b/AxonIvyPortal/portal-components/.settings/org.eclipse.core.resources.prefs
@@ -0,0 +1,2 @@
+eclipse.preferences.version=1
+encoding/<project>=UTF-8
diff --git a/AxonIvyPortal/portal-components/pom.xml b/AxonIvyPortal/portal-components/pom.xml
@@ -18,6 +18,7 @@
   <properties>
     <ivy.engine.version>11.4.0</ivy.engine.version>
     <build.plugin.version>11.4.0-SNAPSHOT</build.plugin.version>
+    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
   </properties>
   <dependencies>
     <dependency>

diff --git a/...ortal/portal-components/processes/Functional Processes/PortalComponentErrorHandler.p.json b/...ortal/portal-components/processes/Functional Processes/PortalComponentErrorHandler.p.json
@@ -43,11 +43,12 @@
       "config" : {
         "output" : {
           "code" : [
+            "import org.apache.log4j.Level;",
             "import com.axonivy.portal.components.ivydata.exception.PortalIvyDataException;",
             "import com.axonivy.portal.components.util.ErrorHandler;",
             "",
             "for (PortalIvyDataException exception : in.exceptions) {",
-            "  ErrorHandler.addError(org.apache.log4j.Priority.ERROR, exception);",
+            "  ErrorHandler.addError(exception);",
             "}"
           ]
         }

diff --git a/...l-components/src/com/axonivy/portal/components/publicapi/PortalGlobalGrowInIFrameAPI.java b/...l-components/src/com/axonivy/portal/components/publicapi/PortalGlobalGrowInIFrameAPI.java
diff --git a/...tal-components/src/com/axonivy/portal/components/publicapi/PortalNavigatorInFrameAPI.java b/...tal-components/src/com/axonivy/portal/components/publicapi/PortalNavigatorInFrameAPI.java
@@ -28,12 +28,12 @@ public static void navigateToUrl(String url) {
 		PrimeFaces.current().executeScript(statement);
 	}
 
-	/**
-	 * Navigate to portal home
-	 */
-	public static void navigateToPortalHome() {
-		navigateToUrl(Ivy.html().applicationHomeRef());
-	}
+  /**
+   * Navigate to portal home
+   */
+  public static void navigateToPortalHome() {
+    navigateToUrl(Ivy.html().applicationHomeLink().getAbsoluteEncoded());
+  }
 
 	/**
 	 * Navigate to PortalEndPage without finishing a task, e.g. clicking on Cancel

diff --git a/...rtal/portal-components/src/com/axonivy/portal/components/service/CaseDocumentService.java b/...rtal/portal-components/src/com/axonivy/portal/components/service/CaseDocumentService.java
@@ -62,16 +62,6 @@ public List<IDocument> getAll() {
     return new ArrayList<>(documents);
   }
 
-  /**
-   * We make it as deprecated from 8.0 Please refer to sub-function process DeleteDocument
-   * 
-   * @param document
-   */
-  @Deprecated
-  public void delete(IDocument document) {
-    documentsOf(iCase).delete(document);
-  }
-
   /**
    * @param document
    * @return streamed content

diff --git a/AxonIvyPortal/portal-components/src/com/axonivy/portal/components/util/ErrorHandler.java b/AxonIvyPortal/portal-components/src/com/axonivy/portal/components/util/ErrorHandler.java
@@ -1,16 +1,15 @@
 package com.axonivy.portal.components.util;
 
-import org.apache.log4j.Priority;
-
 import com.axonivy.portal.components.ivydata.exception.PortalIvyDataException;
+
 import ch.ivyteam.ivy.environment.Ivy;
 
 public class ErrorHandler {
 
   private ErrorHandler() {}
 
-  public static void addError(Priority priority, PortalIvyDataException error) {
-    Ivy.log().log(priority, error.toString());
+  public static void addError(PortalIvyDataException error) {
+    Ivy.log().error(error.toString());
   }
 
 }
diff --git a/...-components/src_hd/com/axonivy/portal/components/ProcessHistory/ProcessHistoryData.d.json b/...-components/src_hd/com/axonivy/portal/components/ProcessHistory/ProcessHistoryData.d.json
@@ -8,7 +8,7 @@
     "type" : "String",
     "modifiers" : [ "PERSISTENT" ]
   }, {
-    "name" : "iCase",
+    "name" : "caze",
     "type" : "ch.ivyteam.ivy.workflow.ICase",
     "modifiers" : [ "PERSISTENT" ]
   }, {

diff --git a/...mponents/src_hd/com/axonivy/portal/components/ProcessHistory/ProcessHistoryProcess.p.json b/...mponents/src_hd/com/axonivy/portal/components/ProcessHistory/ProcessHistoryProcess.p.json
@@ -33,7 +33,7 @@
         "processCall" : "Functional Processes/OpenCaseDetailsHook:call(ch.ivyteam.ivy.workflow.ICase,Boolean,Boolean)",
         "call" : {
           "map" : {
-            "param.caseView" : "in.iCase",
+            "param.caseView" : "in.caze",
             "param.isShowBackButton" : "true",
             "param.isOpenInFrame" : "in.isOpenInFrame"
           }
@@ -59,11 +59,11 @@
         "signature" : "openDetails",
         "input" : {
           "params" : [
-            { "name" : "iCase", "type" : "ch.ivyteam.ivy.workflow.ICase", "desc" : "" },
+            { "name" : "caze", "type" : "ch.ivyteam.ivy.workflow.ICase", "desc" : "" },
             { "name" : "isOpenInFrame", "type" : "Boolean", "desc" : "" }
           ],
           "map" : {
-            "out.iCase" : "param.iCase",
+            "out.caze" : "param.caze",
             "out.isOpenInFrame" : "param.isOpenInFrame"
           }
         },

diff --git a/AxonIvyPortal/portal-migration/webContent/layouts/includes/progress-loader.xhtml b/AxonIvyPortal/portal-migration/webContent/layouts/includes/progress-loader.xhtml
@@ -1,5 +1,6 @@
-<ui:composition xmlns="http://www.w3.org/1999/xhtml" xmlns:f="http://java.sun.com/jsf/core" xmlns:h="http://java.sun.com/jsf/html"
-  xmlns:ui="http://java.sun.com/jsf/facelets" xmlns:p="http://primefaces.org/ui" xmlns:pa="http://primefaces.org/serenity">
+<ui:composition xmlns="http://www.w3.org/1999/xhtml" xmlns:f="http://xmlns.jcp.org/jsf/core"
+  xmlns:h="http://xmlns.jcp.org/jsf/html" xmlns:ui="http://xmlns.jcp.org/jsf/facelets"
+  xmlns:p="http://primefaces.org/ui" xmlns:pa="http://primefaces.org/serenity">
 
   <p:ajaxStatus id="ajaxLoadingStatus">
     <f:facet name="start">

diff --git a/AxonIvyPortal/portal-selenium-test/customized_pom.xml b/AxonIvyPortal/portal-selenium-test/customized_pom.xml
@@ -9,6 +9,7 @@
     <powermock.version>2.0.2</powermock.version>
     <build.plugin.version>11.4.0-SNAPSHOT</build.plugin.version>
     <ivy.engine.version>11.4.0</ivy.engine.version>
+    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
   </properties>
   <dependencies>
     <dependency>

diff --git a/AxonIvyPortal/portal-selenium-test/document_screenshot_pom.xml b/AxonIvyPortal/portal-selenium-test/document_screenshot_pom.xml
@@ -9,6 +9,7 @@
     <powermock.version>2.0.2</powermock.version>
     <build.plugin.version>11.4.0-SNAPSHOT</build.plugin.version>
     <ivy.engine.version>11.4.0</ivy.engine.version>
+    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
   </properties>
   <distributionManagement>
     <repository>

diff --git a/AxonIvyPortal/portal/.settings/org.eclipse.core.resources.prefs b/AxonIvyPortal/portal/.settings/org.eclipse.core.resources.prefs
@@ -0,0 +1,2 @@
+eclipse.preferences.version=1
+encoding/<project>=UTF-8
diff --git a/AxonIvyPortal/portal/pom.xml b/AxonIvyPortal/portal/pom.xml
@@ -19,6 +19,7 @@
   <properties>
     <ivy.engine.version>11.4.0</ivy.engine.version>
     <build.plugin.version>11.4.0-SNAPSHOT</build.plugin.version>
+    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
   </properties>
   <dependencies>
     <dependency>

diff --git a/AxonIvyPortal/portal/processes/Start Processes/PortalStart.p.json b/AxonIvyPortal/portal/processes/Start Processes/PortalStart.p.json
@@ -3029,7 +3029,7 @@
             "call" : {
               "map" : {
                 "param.isTaskFinished" : "in.isTaskFinished",
-                "param.iCase" : "in.caseSelected"
+                "param.caze" : "in.caseSelected"
               }
             }
           },

diff --git a/AxonIvyPortal/portal/src/ch/ivy/addon/portal/generic/bean/UserMenuBean.java b/AxonIvyPortal/portal/src/ch/ivy/addon/portal/generic/bean/UserMenuBean.java
@@ -239,11 +239,6 @@ public boolean isMobileDevice() {
     return RequestUtils.isMobileDevice();
   }
 
-  /**
-   * We moved this method to PortalExceptionBean#getErrorDetailToEndUser
-   * @return system configuration of ErrorDetailToEndUser
-   */
-  @Deprecated
   public boolean getErrorDetailToEndUser() {
     try {
       PortalExceptionBean portalExceptionBean = (PortalExceptionBean) ManagedBeans.find("portalExceptionBean").get();

diff --git a/AxonIvyPortal/portal/src/ch/ivy/addon/portalkit/bean/UserFormatBean.java b/AxonIvyPortal/portal/src/ch/ivy/addon/portalkit/bean/UserFormatBean.java
diff --git a/AxonIvyPortal/portal/src/ch/ivy/addon/portalkit/bo/Announcement.java b/AxonIvyPortal/portal/src/ch/ivy/addon/portalkit/bo/Announcement.java