MARP-452 check accessibility of new website #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heck-accessibility-of-new-Website # Conflicts: # marketplace-ui/src/app/modules/product/product-card/product-card.component.html # marketplace-ui/src/app/modules/product/product.component.html
| height="70" | ||
| [ngSrc]="product | logo" | ||
| [alt]="product.names | multilingualism: languageService.selectedLanguage()" /> | ||
| @if (isShowInRESTClientEditor) { |
There was a problem hiding this comment.
It was not being removed, just re-formatted in the same line in line 5th
| <p class="text-secondary mb-2 mt-3"> | ||
| <app-star-rating [rate]="feedback.rating" (rateChange)="onRateChange($event)" [starClass]="'adding-feedback-star'" | ||
| [ratingStarsClass]="'rating-stars'" /> | ||
| <p [lang]="languageService.selectedLanguage()" [lang]="languageService.selectedLanguage()" |
There was a problem hiding this comment.
There are duplicated code
| {{ tab.label | translate }} | ||
| </a> | ||
| </li> | ||
| } |
There was a problem hiding this comment.
Please check format of this code
| (productStarRatingService.totalComments() > 0 | ||
| ? 'common.feedback.reviewLabel' | ||
| : 'common.feedback.reviewLabelNoYet' | ||
| ) | translate |
There was a problem hiding this comment.
Why remove the pipe translate
| class="form-control bg-secondary me-2 border-0 header__search-input bg-secondary" | ||
| type="input" | ||
| [placeholder]=" | ||
| <input autocomplete="on" [lang]="languageService.selectedLanguage()" class="form-control bg-secondary me-2 border-0 header__search-input bg-secondary" |
There was a problem hiding this comment.
Why do we need turn field autocomplete on?
There was a problem hiding this comment.
Its 1.3.5 Identify input purpose (AA)
…heck-accessibility-of-new-Website # Conflicts: # marketplace-ui/src/app/modules/product/product-detail/product-detail-feedback/product-star-rating-panel/add-feedback-dialog/add-feedback-dialog.component.html # marketplace-ui/src/app/modules/product/product-detail/product-detail.component.html # marketplace-ui/src/app/shared/components/footer/footer.component.html
| [alt]=" | ||
| product.names | multilingualism: languageService.selectedLanguage() | ||
| " | ||
| [lang]="languageService.selectedLanguage()" /> | ||
| @if (isShowInRESTClientEditor) { | ||
| <div | ||
| class="card__tag lh-md px-2 py-1 text-capitalize" |
There was a problem hiding this comment.
Should we add lang for it?
There was a problem hiding this comment.
It does not use translate or multilingualism pipe so it should not include lang
tutn-axonivy
deleted the
feature/MARP-452-Check-accessibility-of-new-Website
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.