Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MARP-992: Custom dropdown should be scrollable #124

Merged

Conversation

nntthuy-axonivy
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Sep 4, 2024
Copy link
Contributor

@ntqdinh-axonivy ntqdinh-axonivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please provide a simple test case to check if the scrollable is applied when there are many options display ( to prevent any one change your code and this issue happen)

Copy link
Contributor

@ntqdinh-axonivy ntqdinh-axonivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nntthuy-axonivy nntthuy-axonivy merged commit d3a9695 into develop Sep 9, 2024
6 checks passed
@nntthuy-axonivy nntthuy-axonivy deleted the feature/MARP-992-Custom-dropdown-should-be-scrollable branch September 9, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants