-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci/lint english #68
Ci/lint english #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks, maybe let's just fix the version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me!
Regarding the comments it did on this PR, I'm not really convinced this linter will be helpful.. Maybe a cron job opening a new PR with spelling and grammar suggestions would fit much, what do you think ? |
If you don't mind, I put the PR in draft while we agree on the best approach. Thx. |
I though it was nice to have a comment on the PR, it gives people a chance to correct their typos. Maybe with a better template? |
Yes effectively, like I wrote in the issue, this action doesn't provide relevant information concerning the errors. It only prints the misspelled words in the PR, without the concerned files and precise locations. We should build our own action, or even a CJ as said by @amimart. What are the advantages of a CronJob compared to an action ? |
4be57ee
to
681b30d
Compare
777dbc2
to
54d7bdc
Compare
@amimart still relevant? |
@ccamel Would have been great, but seems difficult to continue so I'm in favour of closing it. |
Implement an english linter to check the spelling of the whitepaper files.