-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wire config options of transactions for autocli #553
Conversation
WalkthroughThe update in Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- cmd/okp4d/cmd/root.go (3 hunks)
Additional comments: 2
cmd/okp4d/cmd/root.go (2)
- 102-105: Adding
signing.SignMode_SIGN_MODE_TEXTUAL
totx.DefaultSignModes
and settingEnabledSignModes
andTextualCoinMetadataQueryFn
intx.ConfigOptions
are appropriate fixes for the signature verification issue. Ensure that the addition ofSIGN_MODE_TEXTUAL
is compatible with all transaction types in the okp4d network.- 141-144: Repeating the configuration of
EnabledSignModes
andTextualCoinMetadataQueryFn
intx.ConfigOptions
forautoCliOpts
. This repetition is necessary for ensuring that the transaction configuration is consistently applied across different contexts within the application.
c45ef15
to
b95c89c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- cmd/okp4d/cmd/root.go (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- cmd/okp4d/cmd/root.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM :)
🎉 This PR is included in version 7.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Close #551.
(similar to https://github.com/babylonchain/babylon/pull/435/files)
Summary by CodeRabbit