Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set group_by_length to false in all examples #350

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

tmm1
Copy link
Collaborator

@tmm1 tmm1 commented Aug 7, 2023

the README discourages its use

and it makes running the examples slower

@mhenrichsen
Copy link
Collaborator

We discussed the use of group_by_length in the discord channel a week ago or so, and concluded that it was worth setting it to true even though training loss will be a bit more wonky throughout training, it should be worth the better RAM utilization.

@tmm1
Copy link
Collaborator Author

tmm1 commented Aug 7, 2023

@mhenrichsen thanks for that pointer, i updated the README based on the summary of that discussion

@tmm1 tmm1 merged commit f5c11f8 into axolotl-ai-cloud:main Aug 9, 2023
mkeoliya pushed a commit to mkeoliya/axolotl that referenced this pull request Dec 15, 2023
…mples

set `group_by_length` to false in all examples
djsaunde pushed a commit that referenced this pull request Dec 17, 2024
set `group_by_length` to false in all examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants