Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use llama if trust_remote_code is set since that needs to use AutoModel path #266

Merged
merged 2 commits into from
Jul 8, 2023

Conversation

winglian
Copy link
Collaborator

@winglian winglian commented Jul 8, 2023

per emozilla, we shouldn't be using these models when trust_remote_code is set

@winglian winglian merged commit f74edd5 into main Jul 8, 2023
@winglian winglian deleted the trust-remote-no-llama branch July 8, 2023 01:38
@NanoCode012
Copy link
Collaborator

I would think:

  1. Since we warn if this is on, users can be careful and may be responsible for it.
  2. If someone were to customize llama, that would make it incompatible with our code (which can be both pros and cons)
  3. I think if you were to check, we should move this to validate_config function to prevent more validation code in codebase spread out

mkeoliya pushed a commit to mkeoliya/axolotl that referenced this pull request Dec 15, 2023
djsaunde pushed a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants