Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(doc): address missing doc changes #2362

Merged
merged 3 commits into from
Feb 25, 2025
Merged

Fix(doc): address missing doc changes #2362

merged 3 commits into from
Feb 25, 2025

Conversation

NanoCode012
Copy link
Collaborator

Description

  • Fix some minor heading mistakes
  • Mentions multiple times on chat_template eos_token setting

Motivation and Context

How has this been tested?

Screenshots (if appropriate)

Types of changes

Social Handles (Optional)

SalmanMohammadi
SalmanMohammadi approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@SalmanMohammadi SalmanMohammadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bueno

@NanoCode012 @SalmanMohammadi
Update docs/dataset-formats/conversation.qmd
f35e264 
Co-authored-by: salman <salman.mohammadi@outlook.com>
@winglian winglian merged commit 75cbd15 into main Feb 25, 2025
@winglian winglian deleted the fix/doc_part2 branch February 25, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SalmanMohammadi SalmanMohammadi SalmanMohammadi approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NanoCode012 @SalmanMohammadi @winglian