support for custom lr groups for non-embedding modules #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NanoCode012
reviewed
Jan 2, 2025
src/axolotl/core/trainer_builder.py
Outdated
Comment on lines
495
to
502
| if lr_groups_lookup and any( | ||
| group_modules in name for group_modules in lr_groups_lookup | ||
| ): | ||
| lr_group_module = [ | ||
| group_modules | ||
| for group_modules in lr_groups_lookup | ||
| if group_modules in name | ||
| ][0] |
There was a problem hiding this comment.
I think we can refactor the check a bit. It seems like we're creating the list twice. The if check is not necessary as the variable would be empty otherwise
Perhaps
lr_group_modules = [group_modules for group_modules in lr_groups_lookup if group_modules in name]
if any(lr_group_modules):
# use lr_group_modules
src/axolotl/core/trainer_builder.py
Outdated
| group_modules | ||
| for group_modules in lr_groups_lookup | ||
| if group_modules in name | ||
| ][0] |
There was a problem hiding this comment.
Is there a reason we're taking index 0 only? Should we add a check that assert len(..) == 1?
invert name check for group modules include lr_groups in training args additional conditional for creating optimizer fix regular params as w weight decay fix lookup and add docs
NJordan72
pushed a commit
to NJordan72/axolotl
that referenced
this pull request
Jan 28, 2025
…oud#2213) * support for custom lr groups for non-embedding modules invert name check for group modules include lr_groups in training args additional conditional for creating optimizer fix regular params as w weight decay fix lookup and add docs * address pr feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.