-
-
Notifications
You must be signed in to change notification settings - Fork 958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use apply_chat_template to find turn boundaries and allow tool_calling field #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the unit test to check over the various tokenizers. There's still cases of mistral failing (but due to the test, not the source). I will rewrite the test to remove calls to |
a63f47f
to
0c9237f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our prior turn matching code depended on the
content
being encoded to be consistent despite having special tokens in front of it (like with Gemma tokenizer).However, this is not the case with Mistral tokenizer.
mistral:
Now, we use a dummy message to with
apply_chat_template
to figure out where the content begins and ends. This also decreases our dependence on always expectingcontent
to be available, when it would not be for some tool_calling cases.This PR also supersedes #2115 and should work with tool_calling datasets
with one caveat, it cannot detect that the tool turn's EOT but since we don't want to train on tool outputs, this should be fine for now,fixed.TODO:
train_on_eos: turn
by defaultBreaking change:
field_messages
now defaults tomessages
. The docs were correct, but the code didn't reflect this.train_on_eos: turn
roles_to_train: ["assistant"]
Motivation and Context
How has this been tested?
Ran with these
Screenshots (if appropriate)
Types of changes
Social Handles (Optional)