Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has come objective fixing the templates and making them match as closesly as possible the ground truth (Mistral Common), a document delves into details this issue here.
Motivation and Context
This PR should make the templates match properly the corresponding tokenizer of mistral models, it does not tackle function calling but the basic instruction template. It is possible to use the hugging face templates if function calling is supported by Axolotl.
The previous template was not correct, and only matched partially the expected format, this format that will be used assumes that the BOS is not added by default, since im new to Axolotl feel free to confirm this is the proper way to do it!
How has this been tested?
I did not test heavily since I am aware this templates are correct, the only possible issue would depend on how Axolotl implements it, and I may lack the insights confirm it will work out of the box and match perfectly, my main 2 concerns are:
The current templates will format it as such:
V1
V2
V3-Tekken
Types of changes
Simple Jinja templates.