Debugger step and follow commands #340
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazsi
force-pushed
the
debugger-follow-command
branch
3 times, most recently
from
a36329b to
d1d8188
Compare
bazsi
force-pushed
the
debugger-follow-command
branch
from
d1d8188 to
bfd41fc
Compare
bazsi
force-pushed
the
debugger-follow-command
branch
from
bfd41fc to
5c8539a
Compare
bazsi
force-pushed
the
debugger-follow-command
branch
from
5c8539a to
261e471
Compare
Instead of using "NULL" as the indicator for the end of the lines to print, just pass the number of entries in the lines array. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
The mode field in debugger determines how we respond to trace and breakpoints and is used by the hook to trigger various debugging scenarios. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Some breakpoints are not interesting once the mode changes, even though they were submitted by the pipe hook and are waiting to be resumed. Let's quickly acknowledge them and don't bother the user. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Also, stop at the prompt immediately, instead of wait for a message. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
bazsi
force-pushed
the
debugger-follow-command
branch
from
261e471 to
b0c2c36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds multiple modes of operation to the debugger. Previously, we only had the "continue" command, that would run until the next LogPipe element and then stop there for inspecting the state.
This PR adds multiple debugger commands to continue with the evaluation:
This sits on top of #546
The next for this PR is to add a breakpoint mechanism and also to make it possible to stop on filterx expressions.