Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitespace-clean outputs #131

Closed
Gankra opened this issue Feb 16, 2023 · 6 comments · Fixed by #149
Closed

whitespace-clean outputs #131

Gankra opened this issue Feb 16, 2023 · 6 comments · Fixed by #149
Labels
Milestone

Comments

@Gankra
Copy link
Contributor

Gankra commented Feb 16, 2023

the generated CI/installers contain a little bit of trailing/mixed whitespace and that's gonna annoy people. I thought i flushed it out but at least the CI still has some :(

@Gankra Gankra added the bug Something isn't working label Feb 16, 2023
@Gankra Gankra added this to the 0.0.3 milestone Feb 16, 2023
@Gankra
Copy link
Contributor Author

Gankra commented Feb 16, 2023

maaaaybe fixed on tip, so prerelease-03 should have the fixes? (had a bit of a caching struggle so ended up just pushing)

@Gankra
Copy link
Contributor Author

Gankra commented Feb 21, 2023

This is still clearly an issue, I have no idea why running cargo dist generate-ci on my machine produces weird mixed line-endings. The inputs are all LF-only, afaict? Unless this is a fucked up "my own tools are hiding line-ending stuff from me" problem.

@ashleygwilliams
Copy link
Member

@Gankra what editor are you using? (i think it may be a "your tools are hiding stuff" situation)

@Gankra
Copy link
Contributor Author

Gankra commented Feb 21, 2023

I used vscode to change all the line endings to LF-only, and inspecting with sublime-text seems to confirm this worked, even downloading raw files from github... but maybe there's something I'm missing?

@Gankra
Copy link
Contributor Author

Gankra commented Feb 21, 2023

it's poooossible this is actually fixed on tip but some more boostraps need to settle things?

@Gankra
Copy link
Contributor Author

Gankra commented Feb 21, 2023

OH OH THIS WOULD BE SO EVIL

IT'S POSSIBLE THAT GITHUB CI HAS git config --global core.autocrlf true SET AND SO THE OFFICIAL BUILDS HAVE THE TEMPLATES THAT ARE BAKED INTO THE BINARIES AT BUILD TIME REWRITTEN TO HAVE CRLF ENDINGS AAAAAAAA

mistydemeo added a commit that referenced this issue Jun 17, 2024
chore(deps): bump thiserror from 1.0.60 to 1.0.61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants