Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux WebView implementation #1985

Merged
merged 16 commits into from
Jun 13, 2024
Merged

Conversation

IamSanjid
Copy link
Contributor

Describe your changes

Tried to follow the implementation of webview and this pull request.
Windows(1st) and Linux Debian VM XWayland/X11(2nd) comparison:
windows
linux-debian-vm

Issue ticket number and link

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

@IamSanjid IamSanjid marked this pull request as draft June 11, 2024 09:21
@IamSanjid IamSanjid marked this pull request as ready for review June 11, 2024 15:34
@halx99 halx99 added the enhancement New feature or request label Jun 12, 2024
@halx99 halx99 added this to the 2.1.4 milestone Jun 12, 2024
@halx99 halx99 merged commit 6cb7618 into axmolengine:dev Jun 13, 2024
28 of 29 checks passed
@IamSanjid IamSanjid deleted the linux-webview-new branch June 19, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants