Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Calculate safe area inset values for devices with rounded corners #1934

Merged
merged 2 commits into from
May 28, 2024

Conversation

rh101
Copy link
Contributor

@rh101 rh101 commented May 28, 2024

Describe your changes

The changes in this PR will attempt to calculate the correct safe area values for devices with rounded corners. This will only apply for Android 12/API31+, otherwise it will revert back the existing calculations.

Issue ticket number and link

#1876

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

@rh101 rh101 marked this pull request as draft May 28, 2024 04:37
@rh101 rh101 marked this pull request as ready for review May 28, 2024 04:47
@halx99 halx99 linked an issue May 28, 2024 that may be closed by this pull request
@halx99 halx99 added this to the 2.1.4 milestone May 28, 2024
@halx99 halx99 added the enhancement New feature or request label May 28, 2024
@halx99 halx99 merged commit b54775d into axmolengine:dev May 28, 2024
29 checks passed
@rh101 rh101 deleted the android-round-corners branch May 28, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android: bug in getSafeAreaRect calculations
2 participants