chore: clippy --fix

snark-verifier-sdk/src/halo2/aggregation.rs

@@ -90,7 +90,7 @@ impl VerifierUniversality {
 
 #[allow(clippy::type_complexity)]
 /// Core function used in `synthesize` to aggregate multiple `snarks`.
-///  
+///
 /// Returns the assigned instances of previous snarks and the new final pair that needs to be verified in a pairing check.
 /// For each previous snark, we concatenate all instances into a single vector. We return a vector of vectors,
 /// one vector per snark, for convenience.
@@ -360,8 +360,7 @@ pub enum AssignedTranscriptObject {
 ///
 /// ## Notes
 /// - This function does _not_ expose any public instances.
-/// - `svk` is the generator of the KZG trusted setup, usually gotten via `params.get_g()[0]`
-/// (avoids having to pass `params` into function just to get generator)
+/// - `svk` is the generator of the KZG trusted setup, usually gotten via `params.get_g()[0]` (avoids having to pass `params` into function just to get generator)
 ///
 /// ## Universality
 /// - If `universality` is not `None`, then the verifying keys of each snark in `snarks` is loaded as a witness in the circuit.

snark-verifier-sdk/src/halo2/utils.rs

@@ -31,7 +31,7 @@ pub struct AggregationDependencyIntentOwned {
     pub agg_vk_hash_data: Option<((usize, usize), Fr)>,
 }
 
-impl<'a> AggregationDependencyIntent<'a> {
+impl AggregationDependencyIntent<'_> {
     /// Converts `self` into `PlonkProtocol`
     pub fn compile(self, params: &ParamsKZG<Bn256>) -> PlonkProtocol<G1Affine> {
         compile(

snark-verifier-sdk/src/lib.rs

@@ -169,28 +169,3 @@ pub fn write_instances(instances: &[&[Fr]], path: impl AsRef<Path>) {
     let f = BufWriter::new(File::create(path).unwrap());
     bincode::serialize_into(f, &instances).unwrap();
 }
-
-#[cfg(feature = "zkevm")]
-mod zkevm {
-    use super::CircuitExt;
-    use eth_types::Field;
-    use zkevm_circuits::{evm_circuit::EvmCircuit, state_circuit::StateCircuit};
-
-    impl<F: Field> CircuitExt<F> for EvmCircuit<F> {
-        fn instances(&self) -> Vec<Vec<F>> {
-            vec![]
-        }
-        fn num_instance(&self) -> Vec<usize> {
-            vec![]
-        }
-    }
-
-    impl<F: Field> CircuitExt<F> for StateCircuit<F> {
-        fn instances(&self) -> Vec<Vec<F>> {
-            vec![]
-        }
-        fn num_instance(&self) -> Vec<usize> {
-            vec![]
-        }
-    }
-}

snark-verifier/src/loader/halo2/shim.rs

@@ -256,7 +256,7 @@ mod halo2_lib {
         }
     }
 
-    impl<'chip, C: CurveAffineExt> EccInstructions<C> for BaseFieldEccChip<'chip, C>
+    impl<C: CurveAffineExt> EccInstructions<C> for BaseFieldEccChip<'_, C>
     where
         C::ScalarExt: BigPrimeField,
         C::Base: BigPrimeField,

snark-verifier/src/pcs/kzg/accumulator.rs

@@ -205,8 +205,8 @@ mod halo2 {
         use halo2_base::utils::CurveAffineExt;
         use halo2_ecc::ecc::BaseFieldEccChip;
 
-        impl<'chip, C, const LIMBS: usize, const BITS: usize>
-            LimbsEncodingInstructions<C, LIMBS, BITS> for BaseFieldEccChip<'chip, C>
+        impl<C, const LIMBS: usize, const BITS: usize>
+            LimbsEncodingInstructions<C, LIMBS, BITS> for BaseFieldEccChip<'_, C>
         where
             C: CurveAffineExt,
             C::ScalarExt: BigPrimeField,

snark-verifier/src/system/halo2/transcript/halo2.rs

@@ -464,7 +464,7 @@ mod halo2_lib {
     use halo2_base::utils::{BigPrimeField, CurveAffineExt};
     use halo2_ecc::ecc::BaseFieldEccChip;
 
-    impl<'chip, C: CurveAffineExt> NativeEncoding<C> for BaseFieldEccChip<'chip, C>
+    impl<C: CurveAffineExt> NativeEncoding<C> for BaseFieldEccChip<'_, C>
     where
         C::Scalar: BigPrimeField,
         C::Base: BigPrimeField,

snark-verifier/src/util/msm.rs

@@ -23,7 +23,7 @@ pub struct Msm<'a, C: CurveAffine, L: Loader<C>> {
     bases: Vec<&'a L::LoadedEcPoint>,
 }
 
-impl<'a, C, L> Default for Msm<'a, C, L>
+impl<C, L> Default for Msm<'_, C, L>
 where
     C: CurveAffine,
     L: Loader<C>,
@@ -169,7 +169,7 @@ where
     }
 }
 
-impl<'a, C, L> MulAssign<&L::LoadedScalar> for Msm<'a, C, L>
+impl<C, L> MulAssign<&L::LoadedScalar> for Msm<'_, C, L>
 where
     C: CurveAffine,
     L: Loader<C>,
@@ -194,7 +194,7 @@ where
     }
 }
 
-impl<'a, C, L> Sum for Msm<'a, C, L>
+impl<C, L> Sum for Msm<'_, C, L>
 where
     C: CurveAffine,
     L: Loader<C>,

snark-verifier/src/verifier/plonk/proof.rs

@@ -197,7 +197,7 @@ where
         protocol: &'a PlonkProtocol<C, L>,
         common_poly_eval: &CommonPolynomialEvaluation<C, L>,
         evaluations: &mut BTreeMap<Query, L::LoadedScalar>,
-    ) -> Result<Vec<Msm<C, L>>, Error> {
+    ) -> Result<Vec<Msm<'a, C, L>>, Error> {
         let loader = common_poly_eval.zn().loader();
         let mut commitments = iter::empty()
             .chain(protocol.preprocessed.iter().map(Msm::base))