Skip to content

Commit

Permalink
Update mod.rs
Browse files Browse the repository at this point in the history
  • Loading branch information
nnsW3 authored Sep 24, 2024
1 parent 3333067 commit c1179c0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions hashes/zkevm/src/keccak/vanilla/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ impl<F: Field> KeccakCircuitConfig<F> {
// that allows reusing the same parts in an optimal way for the chi step.
// We can save quite a few columns by not recombining the parts after rho/pi and
// re-splitting the words again before chi. Instead we do chi directly
// on the output parts of rho/pi. For rho/pi specially we do
// on the output parts of rho/pi. For rho/pi especially we do
// `s[j][2 * i + 3 * j) % 5] = normalize(rot(s[i][j], RHOM[i][j]))`.
cell_manager.start_region();
let mut lookup_counter = 0;
Expand All @@ -279,7 +279,7 @@ impl<F: Field> KeccakCircuitConfig<F> {
// extra additional cells or selectors we have to put all `s[i]`'s on the same
// row. This isn't that strong of a requirement actually because we the
// words are split into multiple parts, and so only the parts at the same
// position of those words need to be on the same row.
// position of those words needs to be on the same row.
let target_word_sizes = target_part_sizes(part_size);
let num_word_parts = target_word_sizes.len();
let mut rho_pi_chi_cells: [[[Vec<Cell<F>>; 5]; 5]; 3] = array_init::array_init(|_| {
Expand Down Expand Up @@ -357,7 +357,7 @@ impl<F: Field> KeccakCircuitConfig<F> {
let mut lookup_counter = 0;
let part_size_base = get_num_bits_per_base_chi_lookup(k);
for idx in 0..num_columns {
// First fetch the cells we wan to use
// First fetch the cells we want to use
let mut input: [Expression<F>; 5] = array_init::array_init(|_| 0.expr());
let mut output: [Expression<F>; 5] = array_init::array_init(|_| 0.expr());
for c in 0..5 {
Expand Down

0 comments on commit c1179c0

Please sign in to comment.