Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] crosschain run function #27

Merged
merged 1 commit into from
Jun 20, 2024
Merged

[fix] crosschain run function #27

merged 1 commit into from
Jun 20, 2024

Conversation

ytham
Copy link
Contributor

@ytham ytham commented Jun 20, 2024

Targets feat/crosschain:

  • Fixes _run function CLI args which incorrectly sets the sourceChainId as the targetChainId

before:

    │   │   ├─ [0] VM::parseJsonUint("<stringified JSON>", ".args.sourceChainId") [staticcall]
    │   │   │   └─ ← [Return] 84532 [8.453e4]

after:

    │   │   ├─ [0] VM::parseJsonUint("<stringified JSON>", ".args.sourceChainId") [staticcall]
    │   │   │   └─ ← [Return] 11155111 [1.115e7]

@ytham ytham requested a review from yi-sun June 20, 2024 21:22
@ytham ytham merged commit 0950263 into feat/crosschain Jun 20, 2024
4 checks passed
@ytham ytham deleted the fix/crosschain-run-fn branch June 20, 2024 21:29
yi-sun added a commit that referenced this pull request Jul 17, 2024
@yi-sun @ytham
feat: crosschain integration (#23)
b406ae6 
* feat: update for axiom-client v2.1.0

* feat: initial crosschain edits

* feat: update @axiom-crypto/circuit to v2.1.0

* feat: update prove CLI for crosschain

* feat: update interfaces to specify crosschain

* feat: update axiom-std for crosschain

* fix: address comments on address conventions

* wip: checkpoint

* fix: update crosschain configuration to include targetRpcUrl

* chore: add additional secret to CI

* feat: update axiom-client version

* fix: update call

* feat: enable usage of chains without pre-existing deployments in axiom-std (#25)

* feat: enable usage of chains without pre-existing deployments in axiom-std

* chore: update axiom-client

* chore: update axiom-client

* chore: fix CI

* Fix crosschain run function (#27)

* chore: bump SDK version

* chore: add Base Sepolia cross-chain address

---------

Co-authored-by: Yu Jiang Tham <ytham@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yi-sun yi-sun yi-sun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ytham @yi-sun