This repository has been archived by the owner on May 29, 2024. It is now read-only.
fix: Install pip and pip-tools in upgrade script #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UsamaSadiq
approved these changes
Jul 5, 2022
|
Need approval from the owning team as well. |
feanil
reviewed
Aug 10, 2022
requirements/common_constraints.txt
Outdated
| @@ -0,0 +1,25 @@ | |||
| # A central location for most common version constraints | |||
There was a problem hiding this comment.
@Jawayria should this file be a copy or should it just be linking to the central constraints file?
There was a problem hiding this comment.
We mostly do this when we have to override some constraint but it isn't needed here so updated the PR
feanil
approved these changes
Aug 11, 2022
Oh yes, Thanks for the commit |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the upgrade target script to check the compatibility of upgraded pip and pip-tools versions. For reference, look at this openedx/edx-repo-health#271 for new check added in edx-repo-health.