Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add confidence votes deck #225

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Gopikrishna19
Copy link

@Gopikrishna19 Gopikrishna19 commented Apr 19, 2024

As part of our objective/key results, we vote on confidence in finishing the KR by the end of a quarter. And we vote it from 0-10.
We love your app. Please merge this and release it for us to use this feature. It'd be incredibly useful to have it in the dropdown.

As part of our object/key results we vote on confidence in finishing the KR by the end of a quarter. And we vote it from 0-10
@axeleroy
Copy link
Owner

axeleroy commented Apr 20, 2024

Hello,

Thank you for you PR! Adding a new deck also requires updating the back-end code: https://github.com/axeleroy/self-host-planning-poker/blob/main/flask/gamestate/deck.py (the back-end saves the deck to the current game and checks that users do not send bogus values)

But I believe you could add new values to the TRUST_VOTE deck instead, as it was added to achieve the same goal (teams in my previous company us this deck to vote on their confidence on achieving sprints objectives during PI Planning)

@Gopikrishna19
Copy link
Author

I'll update it per your recommendation.

@Gopikrishna19
Copy link
Author

@axeleroy updated. I extended the TRUST_VOTE instead of adding a new one.

@axeleroy
Copy link
Owner

Great, but you still have to add the new values in the back-end, otherwise it'll just throw an error and won't update the selected value.

@Gopikrishna19
Copy link
Author

Gotcha, added that as well.

@Gopikrishna19
Copy link
Author

@axeleroy do you require me to add anything else to get this merged? Please let me know :)

@Gopikrishna19
Copy link
Author

@axeleroy can this be merged, please?

@Gopikrishna19
Copy link
Author

@axeleroy can this be merged so we can use the new changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants