feat: add multiarch build and release #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggutoski
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
Approving as codeowner but @talalashraf or @erain9 should approve before merging.
This PR subsumes #274 so we can close that after merge.
milapsheth
approved these changes
Mar 5, 2022
| @@ -36,59 +37,102 @@ jobs: | |||
| submodules: recursive | |||
|
|
|||
| - name: Install Cosign | |||
| if: matrix.os == 'ubuntu-18.04' && matrix.arch == 'amd64' | |||
There was a problem hiding this comment.
because it is related to docker images. Binaries are signed in gpg section
| run: | | ||
| curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y | ||
|
|
||
| - name: build binaries for Linux/MacOS |
There was a problem hiding this comment.
Suggested change
| - name: build binaries for Linux/MacOS | |
| - name: Build binaries |
Perhaps?
|
Update that will improve the build time.
|
kalidax
force-pushed
the
feat/multiarch-build
branch
from
2c5d941 to
b9f541e
Compare
|
@kalidax @milapsheth @ggutoski can we get this across the line ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This job will
Build and push an image to dockerhub.
Build tofnd binary, gpg sign it, zip it, create sha256 hashes for both zip and binary, upload files to release and S3.
For binary build the job will run on each combination of OS/arch defined in the matrix.
For the container build it will run one time only on ubuntu-18.04/amd64
Multiarch binary tests without docker push, upload to release and upload to s3 have been done here : https://github.com/axelarnetwork/tofnd/actions/runs/1921406385