-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: supports gas payment for two-way calls #72
Merged
npty
merged 17 commits into
main
from
fix/cannot-pay-gas-at-source-chain-for-round-trip
Apr 27, 2023
Merged
feat: supports gas payment for two-way calls #72
npty
merged 17 commits into
main
from
fix/cannot-pay-gas-at-source-chain-for-round-trip
Apr 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npty
changed the title
fix: cannot pay gas at source chain for round trip
feat: supports gas payment for two-way calls
Apr 17, 2023
StephenFluin
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with the latest axelar-examples
with the updated sync/ack example, works well!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for nested contract calls. It does this by checking the transaction receipt log for
ContractCall
orContractCallWithToken
events. If these events are found, the relayer adds a new gas paid event with the deducted gas fee.Other improvements
typechain
to generate types for theGasService
andGateway
contractsIssues
ContractCall
orContractCallWithToken
events. I think we can fix it later because we don't have examples that executescallContract
orcallContractWithToken
multiple times in the destination contract.How to test against axelar-examples?
npm install
axelar-examples
, runnpm install @axelar-network/axelar-local-dev@relative-path-to-axelar-local-dev
axelar-examples
, runnpm run test